Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate default retry configuration options #231

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Conversation

averche
Copy link
Collaborator

@averche averche commented Sep 13, 2023

Description

Populate the required retry parameters with defaults if omitted.

Resolves #229

How has this been tested?

Adjusted the clone test to account for func pointers.

@averche averche requested a review from a team as a code owner September 13, 2023 16:59
client_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dhuckins dhuckins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending comment update

@averche averche merged commit ff66746 into main Sep 13, 2023
4 checks passed
@averche averche deleted the fill-default-retry-config branch September 13, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nil pointer dereference errors when setting partial values for vault.RetryConfiguration
2 participants