Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RekeyAttempt Types #252

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SEANDOUGHTY
Copy link

@SEANDOUGHTY SEANDOUGHTY commented Feb 15, 2024

Description

  1. The type of started in a rekey attempt should be boolean instead of string
  2. Nounce should be nonce

Resolves # (issue)

This resolves: #251

@SEANDOUGHTY SEANDOUGHTY requested a review from a team as a code owner February 15, 2024 00:16
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 15, 2024

CLA assistant check
All committers have signed the CLA.

@SEANDOUGHTY SEANDOUGHTY changed the title change RekeyAttempt started type from string to bool Fix RekeyAttempt Types Feb 15, 2024
@averche
Copy link
Collaborator

averche commented Feb 19, 2024

Thank you for contributing to the library, @SEANDOUGHTY!

The openapi.json file in this repo is generated from Vault server using gen_openapi.sh so the problem needs to be addressed there first.

I've put together a small PR (hashicorp/vault#25509) to address this at the source. Once merged, I'll regenerate openapi.json and push it here as well :)

@SEANDOUGHTY
Copy link
Author

Thank you for contributing to the library, @SEANDOUGHTY!

The openapi.json file in this repo is generated from Vault server using gen_openapi.sh so the problem needs to be addressed there first.

I've put together a small PR (hashicorp/vault#25509) to address this at the source. Once merged, I'll regenerate openapi.json and push it here as well :)

Sounds good! It looks like that PR just got approved 💯

@SEANDOUGHTY
Copy link
Author

Can we complete this PR now?

@averche
Copy link
Collaborator

averche commented Mar 6, 2024

Can we complete this PR now?

Sorry, it's been busy couple of weeks, I will take care of it this week.

@SEANDOUGHTY
Copy link
Author

@averche any update on getting this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot unmarshal into Go struct RekeyAttemptReadProgressResponse
3 participants