feature: imagePullSecrets from string array. #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benashz
force-pushed
the
VAULT-2829/imagePullSecrets-string-values
branch
from
863f0ef
to
500911a
Compare
* allow configuring imagePullSecrets from an array of strings in addition to the already supported array of maps
benashz
force-pushed
the
VAULT-2829/imagePullSecrets-string-values
branch
from
500911a
to
483332a
Compare
|
We may also want to update the comment in values.yaml to mention that an array of strings is now supported as well. |
chukka
reviewed
Jul 23, 2021
illegalnumbers
pushed a commit
to streamnative/vault-helm
that referenced
this pull request
Mar 17, 2022
* allow configuring imagePullSecrets from an array of strings in addition to the already supported array of maps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imagePullSecretsfrom an array of strings inaddition to the already supported array of maps