Add persistentVolumeClaimRetentionPolicy variable to values.yaml #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvoran
reviewed
Nov 8, 2023
values.yaml
Outdated
| # persistentVolumeClaimRetentionPolicy: | ||
| # whenDeleted: Retain | ||
| # whenScaled: Retain | ||
| persistentVolumeClaimRetentionPolicy: null |
There was a problem hiding this comment.
It looks like this setting affects all PVCs on the statefulset, which would affect audit PVCs as well. I wonder if we should we move it up one level, i.e. server.persistentVolumeClaimRetentionPolicy?
I also think we could just default this to {}:
Suggested change
| persistentVolumeClaimRetentionPolicy: null | |
| persistentVolumeClaimRetentionPolicy: {} |
There was a problem hiding this comment.
Hello @tvoran ! Thanks for your feedback.
I've addressed all the changes requested 😄:
- Change default from
nullto empty object{}. - Move key from
server.dataStorage.persistentVolumeClaimRetentionPolicytoserver.persistentVolumeClaimRetentionPolicy - Updated tests to match changes.
- Add new variable into the
values.schema.json(sorry for that, I missed it when I raised this PR!)
Thanks!
alemuro
force-pushed
the
964-add-statefulset-pvc-retention
branch
from
98987a4
to
c782cbb
Compare
This variable is used to set the persistentVolumeClaimRetentionPolicy value in the server-statefulset.yaml template, which is used to configure the retention policy for the PVCs used by the server statefulset.
alemuro
force-pushed
the
964-add-statefulset-pvc-retention
branch
from
c782cbb
to
9fe21c6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new variable on the Helm chart to define the PVC retention policy for the StatefulSet, as requested in #3101
Changes proposed in this PR:
persistentVolumeClaimRetentionPolicyto control the PVC retention policy when the statefulset is deleted or the number of replicas is decreased.How I've tested this PR:
closes #964