Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift/server: readiness probe passes when server uninitialized #966

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Oct 24, 2023

Changes the default server readiness probe (just for openshift) to pass when the server is uninitialized, in order to pass the latest version of the chart-verifier test (see #954 for details).

Also updates the chart-verifier used in our tests to 1.13.0 (latest).

Testing against an OpenShift cluster:

$ go install github.com/redhat-certification/chart-verifier@1.13.0

$ chart-verifier verify ~/projects/vault-helm-review \
  --chart-values ~/projects/vault-helm-review/values.yaml \
  --chart-values ~/projects/vault-helm-review/values.openshift.yaml \
  --timeout 30s -e chart-testing
...
results:
    - check: v1.0/chart-testing
      type: Mandatory
      outcome: PASS
      reason: Chart tests have passed

Fixes #954

Changes the default server readiness probe to pass when the server is
uninitialized, in order to pass the latest version of the
chart-verifier test (see #954) for details.

Also updates the chart-verifier used in our tests to 1.13.0 (latest).
@tvoran tvoran requested a review from a team as a code owner October 24, 2023 06:28
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvoran
Copy link
Member Author

tvoran commented Oct 26, 2023

Thanks!

@tvoran tvoran merged commit 6f3f107 into main Oct 26, 2023
8 checks passed
@tvoran tvoran deleted the VAULT-19836/openshift-readiness branch October 26, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart verification failing due to vault being uninitialized/sealed
2 participants