Prepare for release 0.26.1 #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swenson
approved these changes
Oct 30, 2023
CHANGELOG.md
Outdated
| ## 0.26.0 (October 27, 2023) | ||
|
|
||
| KNOWN ISSUES: | ||
|
|
||
| * The chart will ignore `server.ha.replicas` and always deploy 3 server replicas when `server.ha.enabled=true` unless overridden by command line when issuing the helm command: `--set server.ha.replicas=<some_number>`. Fixed in [GH-961](https://github.com/hashicorp/vault-helm/pull/961) |
There was a problem hiding this comment.
I'm not sure it is necessary to put this here if we are fixing it in 0.26.1?
There was a problem hiding this comment.
I guess I was trying to say that 0.26.0 has a known issue which is fixed in 0.26.1. I was pointing it out because it can be particularly impactful if you were to deploy to a cluster that has it previously pinned to 1 or 5?
Happy to change it if you don't think it's necessary.
|
I'm okay either way. But presumably all bug fixes were known issues in 1 or more prior releases :) |
tvoran
approved these changes
Oct 30, 2023
Thanks, good call. I removed the known issues section and moved some of its contents in support of the "fix". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug preventing templating of
server.ha.replicas.