CreateOperation should only be implemented alongside ExistenceCheck #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcoulombe
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
LGTM thanks for doing this.
I read through the original issue and I agree removing the dead CreateOperation code is better than to introduce an ExistenceCheck that could be breaking for users depending on their ACL policies. I know you have 4 more PRs opened around this issue in repos my team manages, I'll try to go through all PRs today. Cheers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See hashicorp/vault#18492