Add PKCE to OIDC Auth #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
requested review from
austingebauer,
vinay-gopalan and
jasonodonnell
path_oidc.go
Outdated
| @@ -454,6 +454,13 @@ func (b *jwtAuthBackend) createOIDCRequest(config *jwtConfig, role *jwtRole, rol | |||
|
|
|||
| if config.hasType(responseTypeIDToken) { | |||
| options = append(options, oidc.WithImplicitFlow()) | |||
| } else { | |||
There was a problem hiding this comment.
Should we have a strict type for PKCE response type? The else here seems too broad, especially if we add more flows in the future?
There was a problem hiding this comment.
Makes sense to test for responseTypeCode since PKCE only (?) applied there.
There was a problem hiding this comment.
The RFC says that "clients utilizing the Authorization Code Grant are susceptible to the authorization code interception attack". So I agree we should just check for responseTypeCode. I will update the PR. Thanks!
fairclothjm
added a commit
that referenced
this pull request
Dec 7, 2021
* Add PKCE to OIDC authorization code logins * Add tests * fix comment typos * check for code response type Co-authored-by: Jim Kalafut <jkalafut@hashicorp.com>
fairclothjm
added a commit
that referenced
this pull request
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add PKCE to OIDC Auth
Design of Change
use the cap library to set the pkce option
Contributor Checklist
[x] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
[x] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[x] Backwards compatible
Tests