New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remove_instance_name config to CLI and mount config #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
Jul 26, 2022
austingebauer
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have enough context to contribute to the client/server side question, but the code generally LGTM.
calvn
reviewed
Aug 3, 2022
calvn
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit, otherwise LGTM
jasonodonnell
changed the title
Add remove_instance_name config to CLI
Add remove_instance_name config to CLI and mount config
Aug 4, 2022
optiz0r
pushed a commit
to optiz0r/vault-plugin-auth-kerberos
that referenced
this pull request
Jan 8, 2024
hashicorp#69) * Add remove_instance_name config to CLI * Add server side processing * Remove trimming from username * Remove redundant check for trimming * Also split username serverside
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not uncommon when generating keytab files for users to include hostnames in the service principal name, for example:
Some users want the CLI to strip these instances if they're found while parsing the keytab during login to avoid authentication issues when searching LDAP for the user. To do this, I added a new CLI login parameter
remove_instance_name
, which will remove any instance names from the keytab file. It then sends the modified keytab file to Vault to be used for the login request.Using this new parameter, a login might look like this:
To enable server side trimming, I added a new config to the kerberos config, with the same name
remove_instance_name
:vault write auth/kerberos/config \ keytab=@vault.keytab.base64 \ service_account="vault" \ remove_instance_name=true