Prepare for v0.19.0 release #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
reviewed
May 20, 2024
There was a problem hiding this comment.
Looks like we need to bump go-jose otherwise we won't get past security scanner for the release
make dev && scan binary bin/vault-plugin-auth-kubernetes
CGO_ENABLED=0 go build -o bin/vault-plugin-auth-kubernetes cmd/vault-plugin-auth-kubernetes/main.go
go: downloading k8s.io/api v0.29.3
Scanned file:{path:"bin/vault-plugin-auth-kubernetes"} in 4.7s - found 1 result(s)
» Go Modules Scanner
⚠︎ found OSV reported vulnerability GO-2024-2631 in github.com/go-jose/go-jose/v4@v4.0.1
bin/vault-plugin-auth-kubernetes
Zlaticanin
reviewed
May 20, 2024
Co-authored-by: Milena Zlaticanin <60530402+Zlaticanin@users.noreply.github.com>
|
go-jose v4.0.2 seems to still upset the scanner, although https://pkg.go.dev/vuln/GO-2024-2631 seems to think it was resolved. @fairclothjm says go-jose is releasing another patch update next week, so maybe things will be better then? |
|
It looks like v2.6.3 of go-jose avoids the need to try to update to v3 or v4, although it does require a rename of the import from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Release/changelog PR for vault-plugin-auth-kubernetes.
Of note here are updates to go-jose 2.6.0 to 2.6.3 (a direct dependency), and go-jose 4.0.1 to 4.0.3 (an indirect dependency) to resolve GO-2024-2631.