Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send audience to tokenreview api #74

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

rvasilevsf
Copy link
Contributor

This PR addresses #73.

I've tested this with EKS 1.14.
This setup requires a token_reviewer_jwt with system:auth-delegator permissions. Also EKS projected tokens are not issued from kubernetes, but from OIDC (https://oidc.eks.us-east-1.amazonaws.com/id/), so this requires the configuration of issuer as well.

Here's my config:

vault write auth/kubernetes/config \
kubernetes_host=https://CF07473106A573AC4F2567E17CF8B150.gr7.us-east-1.eks.amazonaws.com \
kubernetes_ca_cert=@ca.crt \
issuer="https://oidc.eks.us-east-1.amazonaws.com/id/CF07473106A573AC4F2567E17CF8B150" \
token_reviewer_jwt="<MY_JWT_REVIEWER_TOKEN>"

Old authentication w/o audience also works, just make sure your role isn't provisioned with it and general config issuer is the default one (e.g. no issuer setting).

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 16, 2019

CLA assistant check
All committers have signed the CLA.

@riuvshyn
Copy link
Contributor

can we expect this fix to be included in the next bugfix?

cc @kalafut @jefferai 🙏

@rvasilevsf please sign CLA

@rvasilevsf
Copy link
Contributor Author

I've signed the CLA.
@jasonodonnell would you be able to review the PR?
Thanks.

@rvasilevsf
Copy link
Contributor Author

Ping...

@catsby

@jasonodonnell
Copy link

jasonodonnell commented Dec 3, 2019

Hi @rvasilevsf,

This code looks fine but there isn't any test coverage for the issuer. Can you add some? I will test this on EKS and for backwards compatibility today.

@rvasilevsf
Copy link
Contributor Author

@jasonodonnell there isn't one because this is very specific to AWS.

Copy link

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants