Ensure read config returns correct password policy key #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcman312
approved these changes
Oct 7, 2020
pcman312
approved these changes
Oct 8, 2020
jasonodonnell
added a commit
that referenced
this pull request
Oct 8, 2020
* Ensure read config returns correct password policy key * Revert interface variable name
This was referenced Oct 8, 2020
jasonodonnell
added a commit
that referenced
this pull request
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an inconsistency in
ad/configwhere password policies are set using the keypassword_policybut are returned using a different key whenad/configis read:$ vault write ad/config \ binddn=$USERNAME \ bindpass=$PASSWORD \ url=ldaps://138.91.247.105 \ userdn='dc=example,dc=com' \ password_policy='foobar' \ formatter='' \ length=0 $ vault read ad/config Key Value --- ----- binddn jasonodonnell certificate n/a formatter n/a insecure_tls false last_rotation_tolerance 5 length 0 max_ttl 768h policy_name foobar starttls false tls_max_version tls12 tls_min_version tls12 ttl 768h upndomain n/a url ldaps://138.91.247.105 use_pre111_group_cn_behavior false userdn dc=example,dc=comI've also changed the name of the variables tracking this internally since the word
policyis overloaded in Vault.