Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new endpoint to support rotation of the root password in Azure. I had to rearrange some of the WAL code to support the root rotation because the current WAL rollback code deletes the service principal app when there's an error.
I'm still working on updating the test cases for the new endpoints, but the core logic is ready for review.
Testing
Setting up an Azure root account for Vault can be difficult, but our learn guide does a good job of guiding an operator through it.
After rotation in Azure you can view the new secret attached to the application.