Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 1.9.x: Update authorization to 2018-01-01 preview (#83) #84

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Backport 1.9.x: Update authorization to 2018-01-01 preview (#83) #84

merged 1 commit into from
Nov 24, 2021

Conversation

austingebauer
Copy link
Member

This PR backports #83.

Steps:

  1. git checkout release/vault-1.9.x
  2. git checkout -b backport-pr-83-1.9.x
  3. git cherry-pick 241dd84bc32c0601a459d8e59f7c49a146cc8cd6

@jasonodonnell @austingebauer
Update authorization to 2018-01-01 preview (#83)
bb717e4 
* Update authorization to 2018-01-01 preview

* Fixes AAD tests; Adds coverage for Storage Blob Data Owner in MS graph tests

Co-authored-by: Austin Gebauer <agebauer@hashicorp.com>
@austingebauer austingebauer added this to the 1.9.1 milestone Nov 24, 2021
@austingebauer
Copy link
Member Author

Re-ran tests on this backport:

➜  vault-plugin-secrets-azure git:(backport-pr-83-1.9.x) go test -v -run TestCredentialInteg_msgraph
=== RUN   TestCredentialInteg_msgraph
=== RUN   TestCredentialInteg_msgraph/service_principals
=== PAUSE TestCredentialInteg_msgraph/service_principals
=== CONT  TestCredentialInteg_msgraph/service_principals
--- PASS: TestCredentialInteg_msgraph (0.00s)
    --- PASS: TestCredentialInteg_msgraph/service_principals (17.10s)
PASS
ok      github.com/hashicorp/vault-plugin-secrets-azure 17.464s

➜  vault-plugin-secrets-azure git:(backport-pr-83-1.9.x) go test -v -run TestCredentialInteg_aad
=== RUN   TestCredentialInteg_aad
=== RUN   TestCredentialInteg_aad/service_principals
=== PAUSE TestCredentialInteg_aad/service_principals
=== RUN   TestCredentialInteg_aad/static_service_principals
=== PAUSE TestCredentialInteg_aad/static_service_principals
=== CONT  TestCredentialInteg_aad/service_principals
=== CONT  TestCredentialInteg_aad/static_service_principals
--- PASS: TestCredentialInteg_aad (0.00s)
    --- PASS: TestCredentialInteg_aad/static_service_principals (64.55s)
    --- PASS: TestCredentialInteg_aad/service_principals (119.29s)
PASS
ok      github.com/hashicorp/vault-plugin-secrets-azure 119.577s

@austingebauer austingebauer merged commit 867e8d4 into release/vault-1.9.x Nov 24, 2021
@austingebauer austingebauer deleted the backport-pr-83-1.9.x branch November 24, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvn calvn calvn approved these changes

@kalafut kalafut Awaiting requested review from kalafut

@jasonodonnell jasonodonnell Awaiting requested review from jasonodonnell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@austingebauer @calvn @jasonodonnell