CreateOperation should only be implemented alongside ExistenceCheck (#20

) * CreateOperation should only be implemented alongside ExistenceCheck See hashicorp/vault#18492 * Remove CreateOperation cases in tests too
hashicorp · Jan 19, 2023 · 416e11f · 416e11f
1 parent 327fcc4
commit 416e11f
Show file tree

Hide file tree

Showing 16 changed files with 0 additions and 24 deletions.
diff --git a/path_decrypt.go b/path_decrypt.go
@@ -60,7 +60,6 @@ correct version automatically.
 		},
 
 		Callbacks: map[logical.Operation]framework.OperationFunc{
-			logical.CreateOperation: withFieldValidator(b.pathDecryptWrite),
 			logical.UpdateOperation: withFieldValidator(b.pathDecryptWrite),
 		},
 	}

diff --git a/path_decrypt_test.go b/path_decrypt_test.go
@@ -19,8 +19,6 @@ import (
 func TestPathDecrypt_Write(t *testing.T) {
 
 	t.Run("field_validation", func(t *testing.T) {
-
-		testFieldValidation(t, logical.CreateOperation, "decrypt/my-key")
 		testFieldValidation(t, logical.UpdateOperation, "decrypt/my-key")
 	})
 

diff --git a/path_encrypt.go b/path_encrypt.go
@@ -59,7 +59,6 @@ limitations by key types.
 		},
 
 		Callbacks: map[logical.Operation]framework.OperationFunc{
-			logical.CreateOperation: withFieldValidator(b.pathEncryptWrite),
 			logical.UpdateOperation: withFieldValidator(b.pathEncryptWrite),
 		},
 	}

diff --git a/path_encrypt_test.go b/path_encrypt_test.go
@@ -13,8 +13,6 @@ import (
 func TestPathEncrypt_Write(t *testing.T) {
 
 	t.Run("field_validation", func(t *testing.T) {
-
-		testFieldValidation(t, logical.CreateOperation, "encrypt/my-key")
 		testFieldValidation(t, logical.UpdateOperation, "encrypt/my-key")
 	})
 

diff --git a/path_keys_deregister.go b/path_keys_deregister.go
@@ -29,7 +29,6 @@ it will be left untouched.
 		},
 
 		Callbacks: map[logical.Operation]framework.OperationFunc{
-			logical.CreateOperation: withFieldValidator(b.pathKeysDeregisterWrite),
 			logical.UpdateOperation: withFieldValidator(b.pathKeysDeregisterWrite),
 			logical.DeleteOperation: withFieldValidator(b.pathKeysDeregisterWrite),
 		},

diff --git a/path_keys_deregister_test.go b/path_keys_deregister_test.go
@@ -10,8 +10,6 @@ import (
 func TestPathKeysDeregister_Write(t *testing.T) {
 
 	t.Run("field_validation", func(t *testing.T) {
-
-		testFieldValidation(t, logical.CreateOperation, "keys/deregister/my-key")
 		testFieldValidation(t, logical.UpdateOperation, "keys/deregister/my-key")
 	})
 

diff --git a/path_keys_register.go b/path_keys_register.go
@@ -54,7 +54,6 @@ not exist at creation time.
 		},
 
 		Callbacks: map[logical.Operation]framework.OperationFunc{
-			logical.CreateOperation: withFieldValidator(b.pathKeysRegisterWrite),
 			logical.UpdateOperation: withFieldValidator(b.pathKeysRegisterWrite),
 		},
 	}

diff --git a/path_keys_register_test.go b/path_keys_register_test.go
@@ -11,8 +11,6 @@ import (
 func TestPathKeysRegister_Write(t *testing.T) {
 
 	t.Run("field_validation", func(t *testing.T) {
-
-		testFieldValidation(t, logical.CreateOperation, "keys/register/my-key")
 		testFieldValidation(t, logical.UpdateOperation, "keys/register/my-key")
 	})
 

diff --git a/path_keys_rotate.go b/path_keys_rotate.go
@@ -46,7 +46,6 @@ point to a valid Google Cloud KMS crypto key.
 		},
 
 		Callbacks: map[logical.Operation]framework.OperationFunc{
-			logical.CreateOperation: withFieldValidator(b.pathKeysRotateWrite),
 			logical.UpdateOperation: withFieldValidator(b.pathKeysRotateWrite),
 		},
 	}

diff --git a/path_keys_rotate_test.go b/path_keys_rotate_test.go
@@ -10,8 +10,6 @@ import (
 func TestPathKeysRotate_Write(t *testing.T) {
 
 	t.Run("field_validation", func(t *testing.T) {
-
-		testFieldValidation(t, logical.CreateOperation, "keys/rotate/my-key")
 		testFieldValidation(t, logical.UpdateOperation, "keys/rotate/my-key")
 	})
 

diff --git a/path_keys_verify.go b/path_keys_verify.go
@@ -64,7 +64,6 @@ Base64-encoded signature to use for verification. This field is required.
 		},
 
 		Callbacks: map[logical.Operation]framework.OperationFunc{
-			logical.CreateOperation: withFieldValidator(b.pathVerifyWrite),
 			logical.UpdateOperation: withFieldValidator(b.pathVerifyWrite),
 		},
 	}

diff --git a/path_keys_verify_test.go b/path_keys_verify_test.go
@@ -16,8 +16,6 @@ import (
 func TestPathVerify_Write(t *testing.T) {
 
 	t.Run("field_validation", func(t *testing.T) {
-
-		testFieldValidation(t, logical.CreateOperation, "verify/my-key")
 		testFieldValidation(t, logical.UpdateOperation, "verify/my-key")
 	})
 

diff --git a/path_reencrypt.go b/path_reencrypt.go
@@ -58,7 +58,6 @@ unspecified, this defaults to the latest active crypto key version.
 		},
 
 		Callbacks: map[logical.Operation]framework.OperationFunc{
-			logical.CreateOperation: withFieldValidator(b.pathReencryptWrite),
 			logical.UpdateOperation: withFieldValidator(b.pathReencryptWrite),
 		},
 	}

diff --git a/path_reencrypt_test.go b/path_reencrypt_test.go
@@ -11,8 +11,6 @@ import (
 func TestPathReencrypt_Write(t *testing.T) {
 
 	t.Run("field_validation", func(t *testing.T) {
-
-		testFieldValidation(t, logical.CreateOperation, "reencrypt/my-key")
 		testFieldValidation(t, logical.UpdateOperation, "reencrypt/my-key")
 	})
 

diff --git a/path_sign.go b/path_sign.go
@@ -50,7 +50,6 @@ required.
 		},
 
 		Callbacks: map[logical.Operation]framework.OperationFunc{
-			logical.CreateOperation: withFieldValidator(b.pathSignWrite),
 			logical.UpdateOperation: withFieldValidator(b.pathSignWrite),
 		},
 	}

diff --git a/path_sign_test.go b/path_sign_test.go
@@ -23,8 +23,6 @@ import (
 func TestPathSign_Write(t *testing.T) {
 
 	t.Run("field_validation", func(t *testing.T) {
-
-		testFieldValidation(t, logical.CreateOperation, "sign/my-key")
 		testFieldValidation(t, logical.UpdateOperation, "sign/my-key")
 	})