Remove the downgrade code #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxb
added a commit
to maxb/vault-plugin-secrets-kv
that referenced
this pull request
Jul 25, 2023
The `Passthrough` interface ceased to be used after some code was removed in hashicorp#11. The `GenerateLeases` function ceased to be used when this code was made capable of being a separate plugin, rather than a builtin part of Vault - credit to @remilapeyre for noticing this in hashicorp#55 - I'm just cherrypicking the removal of unused code from that old unmerged PR, whilst I had some other unused code to PR the removal of too.
Merged
averche
pushed a commit
that referenced
this pull request
Jul 25, 2023
The `Passthrough` interface ceased to be used after some code was removed in #11. The `GenerateLeases` function ceased to be used when this code was made capable of being a separate plugin, rather than a builtin part of Vault - credit to @remilapeyre for noticing this in #55 - I'm just cherrypicking the removal of unused code from that old unmerged PR, whilst I had some other unused code to PR the removal of too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.