Update path definitions to work with OpenAPI #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Vault dependency.
vishalnayak
approved these changes
Nov 5, 2018
briankassouf
approved these changes
Nov 6, 2018
This was referenced Jul 25, 2023
maxb
added a commit
to maxb/vault-plugin-secrets-kv
that referenced
this pull request
Jul 25, 2023
A regression was introduced in hashicorp#17, in 2018. Better late than never, let's fix it. This will open the door to considering deleting the second copy of the KV v1 source code within the Vault repo, and just referring to this as the canonical copy. The fix selectively reverts some parts of hashicorp#17, renames `handleRead` to `handleReadOrRenew`, and adds some detailed comments to explain the subtlety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessarily update Vault dependency.