Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Renew operation for KV v1 #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Renew operation for KV v1 #55

wants to merge 1 commit into from

Commits on Nov 14, 2021

  1. Fix Renew operation for KV v1 

    Using `handleRead` as the `Renew` method for KV v1 is incorrect and
would fail with the error:

	http: panic serving 127.0.0.1:59579: field path not in the schema

in the Vault server without returning a response.

This fixes by returning an empty response which signals properly that
the secret cannot be renewed.

Also remove `GeneratesLeases()` which was never used and fix a typo in
an error message.
    @remilapeyre
    remilapeyre committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    39f481f View commit details
    Browse the repository at this point in the history