return 404 resp for patch when entry does not exist #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Vault PR #12687 introduced a global translation of a nil
logical.Response
for aPatchOperation
to a404 Not Found
response. After further review, this translation cannot be used as there areCreateOperation
andUpdateOperation
handlers that return a nillogical.Response
(ultimately translated to a204 No Content
. The aforementioned global translation has been removed in Vault PR #13167.Design of Change
The
PatchOperation
for the KVv2 data endpoint will now return explicit404 Not Found
responses when an entry does not exist.Related Issues/Pull Requests
#13167