Backport 1.8.x: Fix early rotation for roles with WALs, ensure <=1 WAL per role (#28) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add more WAL logging * Fix early rotation for roles with WALs, handle multiple WALs per role * Respect previous WAL's new password * Ensure only 1 WAL per role * Add a warning to manual rotation response when rotation not immediately successful * Remove re-storing of mount config when rotating unrelated roles * Discard all WALs with a previous rotation time of 0 * Remove deleted WAL IDs from queue items * Delete unused struct fields * Switch from warning to error to correct HTTP status code from 400 -> 500 * Delete WALs on failed role creation or role deletion * Take exclusive lock before reading config * Fix manual rotate not respecting WAL ID * Add tests for processing of stored WALs * Remove unnecessary multierror * Add last check on newPassword
tomhjp
changed the title
calvn
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #28 for 1.8.x