Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape hyphen in encoding regex #338

Closed
wants to merge 1 commit into from
Closed

Conversation

yesmeck
Copy link

@yesmeck yesmeck commented May 2, 2024

I'm not sure if it's intended or not, but I believe the hyphen should be escaped. Otherwise, hyphens in the key name will be encoded, resulting in a wrong key name.

@yesmeck yesmeck requested a review from a team as a code owner May 2, 2024 02:10
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

1 similar comment
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@yesmeck yesmeck closed this May 2, 2024
@yesmeck yesmeck deleted the patch-1 branch May 2, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant