Adds options for mounts #196

petems · 2018-12-19T00:39:51Z

Allows us to check what kv version is mounted
Also allows us to retrieve options from existing
mounts
Restricts to 0.10+ for specs

Closes #195

grosser · 2018-12-26T17:15:09Z

lib/vault/api/sys/mount.rb

-      payload = { type: type }
+    # @param [String] options
+    # mount type specific options that are passed to the backend (optional)
+    def mount(path, type, description = nil, options = {})


prefer that options includes :description ... maybe some fallback if options is not a hash, then treat it as description

Not sure I understand this comment, do you mean that options contains a description? Or to remove the extra attribute?

both :D

def mount(path, type, options = {}) description = (options.is_a?(Hash) ? options[:description] : options)

lib/vault/api/sys/mount.rb

spec/integration/api/sys/mount_spec.rb

grosser · 2018-12-26T17:18:43Z

spec/integration/api/sys/mount_spec.rb

+      it "returns the options from a mount" do
+        next unless has_options_for_mount?
+
+        expect(subject.mount("kv_v2_mount", "kv", 'kv v2 mount', options: {version: "2"})).to be(true)


isn't this supposed to be

Suggested change

expect(subject.mount("kv_v2_mount", "kv", 'kv v2 mount', options: {version: "2"})).to be(true)

expect(subject.mount("kv_v2_mount", "kv", 'kv v2 mount', version: "2")).to be(true)

Nope, it's an options hash containing the entry of version . AFAIK :https://www.vaultproject.io/api/system/mounts.html#options

maxadamo · 2019-01-29T09:17:44Z

will anyone push the merge button? 😺

* Allows us to check what kv version is mounted * Also allows us to retrieve options from existing mounts * Restricts to 0.10+ for specs

* Adds readline for pry * Detect if VAULT_VERSION is unset * Change to the latest 3 releases in Travis

petems mentioned this pull request Dec 19, 2018

Supporting k/v v2 petems/petems-hiera_vault#23

Closed