Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping VaultAuth DRY #341

Closed
bradfordwagner opened this issue Aug 25, 2023 · 1 comment
Closed

Keeping VaultAuth DRY #341

bradfordwagner opened this issue Aug 25, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bradfordwagner
Copy link

bradfordwagner commented Aug 25, 2023

Is your feature request related to a problem? Please describe.
Configurations for Vault Webhook Injector (vault-k8s) and Vault CSI Provider allow default configuration of the auth mount point, and vault namespace.

I do not want my application teams to need to know about the namespace/mount, unless they are using shared secrets across namespaces.

Describe the solution you'd like

  • If namespace+mount have been configured on the operator then inherit if not defined in VaultAuth.
  • If they haven't then require mount, and leave namespace as optional.
  • Do not reject admission unless mount is not defaulted in the operator, and not defined in VaultAuth kubernetes resource.
  • Apps with method=kubernetes should only care for setting the role/service_account while running operations.
apiVersion: secrets.hashicorp.com/v1beta1
kind: VaultAuth
metadata:
  name: my-app-auth
  namespace: app-ns
spec:
## values which should be defaulted from operator configuration
## they can be overridden here
  method: kubernetes
  namespace: app1
  mount: kubernetes/my-happy-cluster
### end overrides
  kubernetes:
    role: my_app_role
    serviceAccount: app-sa
    audiences:
      - vault

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

@bradfordwagner bradfordwagner added the enhancement New feature or request label Aug 25, 2023
@bradfordwagner
Copy link
Author

This is a duplicate of #274

@bradfordwagner bradfordwagner closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2023
@benashz benashz added this to the v0.6.0 milestone Jan 17, 2024
@benashz benashz self-assigned this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants