Adding integration testing to the repo #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setup is similar to our other k8s projects (make setup-integration-test, etc.), and the test itself is using terratest to configure vault and test the operator.
Use code instead of yaml to create the VaultSecret in the test. Wait for the k8s secret to be updated instead of sleeping.
benashz
reviewed
Dec 14, 2022
| # kind-k8s-version: [1.22.15, 1.23.13, 1.24.7] | ||
| # vault-version: [1.10.9, 1.11.6] | ||
| exclude: | ||
| - kind-k8s-version: 1.24.7 |
There was a problem hiding this comment.
Yeah, this setup seems a bit onerous to maintain, but I guess it does the job.
| @@ -0,0 +1,16 @@ | |||
| # Copyright (c) HashiCorp, Inc. | |||
There was a problem hiding this comment.
I wonder if just doing a kubectl port-forward ... might be simpler than setting up the hostport stuff? Not sure which is the best approach.
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
fail test if KIND_CLUSTER_NAME not set use unique ids for vault and k8s namespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs the operator integration tests with the last four version of Kubernetes, and the last three versions of Vault.
The setup is similar to our other k8s projects (make setup-integration-test, etc.), and the test itself is using a bit of terratest to configure vault and test the operator.
Makefile target
setup-integrationcalls helm to install vault and applies the hostPort patch (setup-integration-test-common), builds the docker image (ci-docker-build) and copies it to kind (ci-deploy-kind).Makefile target(s)
integration-test/integration-test-entruns the tests underintegrationtest/, which applies the terraform underintegrationtest/vaultsecret-kv/terraform/to configure the vault kv2 secrets engine, sets a secret in Vault, creates a VaultSecret CR, checks the resulting k8s Secret, updates the Vault secret, and checks that the update is reflected in the k8s Secret.Still TODO: