Truncate pre-delete-controller Job name to 63 characters #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschoche
force-pushed
the
VAULT-22198/truncate-resource-names-v2
branch
from
1e14a8d
to
5fabe07
Compare
kschoche
changed the title
benashz
approved these changes
Dec 19, 2023
chart/templates/_helpers.tpl
Outdated
| @@ -17,13 +17,13 @@ If release name contains chart name it will be used as a full name. | |||
| */}} | |||
| {{- define "vso.chart.fullname" -}} | |||
| {{- if .Values.fullnameOverride }} | |||
| {{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }} | |||
| {{- .Values.fullnameOverride | trunc 27 | trimSuffix "-" }} | |||
There was a problem hiding this comment.
The doc string above should probably be updated, since we are only allowing a release name of 27.
chart/templates/_helpers.tpl
Outdated
| @@ -7,7 +7,7 @@ | |||
| Expand the name of the chart. | |||
| */}} | |||
| {{- define "vso.chart.name" -}} | |||
| {{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" }} | |||
| {{- default .Chart.Name .Values.nameOverride | trunc 27 | trimSuffix "-" }} | |||
There was a problem hiding this comment.
Did we double check that 27 chars was enough, relative to the recently added viewer/editor role resources?
test/unit/deployment.bats
Outdated
| yq 'select(.kind == "Job") | .metadata' | tee /dev/stderr) | ||
|
|
||
| local actual=$(echo "$object" | yq '.name' | tee /dev/stderr) | ||
| [ "${actual}" = "pdcc-abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdef" ] |
There was a problem hiding this comment.
cool, I wonder if we could also assert the length of $actual as well:
Something like:
[ "${#actual}" -eq 63 ]There was a problem hiding this comment.
oooo, nice! thx, have included it in d51cefc
test/unit/deployment.bats
Outdated
| yq 'select(.kind == "Job") | .metadata' | tee /dev/stderr) | ||
|
|
||
| local actual=$(echo "$object" | yq '.name' | tee /dev/stderr) | ||
| [ "${actual}" = "pdcc-release-name-vault-secrets-operator" ] |
There was a problem hiding this comment.
nit: extra leading whitespace
test/unit/deployment.bats
Outdated
| yq 'select(.kind == "Job") | .metadata' | tee /dev/stderr) | ||
|
|
||
| local actual=$(echo "$object" | yq '.name' | tee /dev/stderr) | ||
| [ "${actual}" = "pdcc-abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdef" ] |
There was a problem hiding this comment.
nit: extra leading whitespace
adrianmoisey
pushed a commit
to adrianmoisey/vault-secrets-operator
that referenced
this pull request
Jan 16, 2024
* truncate pre-delete controller job name to 63 chars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncate pre-delete-cleanup-controller to 63 characters
Fixes #260
Closes #476
Closes #499 as duplicate