GetCredentials Bug fix (#13336) (#13337)

* the fix * test coverage
hashicorp · Dec 3, 2021 · 3d69cbb · 3d69cbb
1 parent ab20565
commit 3d69cbb
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 13 deletions.
diff --git a/ui/app/components/get-credentials-card.js b/ui/app/components/get-credentials-card.js
@@ -28,7 +28,7 @@ export default class GetCredentialsCard extends Component {
   @tracked secret = '';
 
   @action
-  async transitionToCredential() {
+  transitionToCredential() {
     const role = this.role;
     const secret = this.secret;
     if (role) {

diff --git a/ui/app/templates/components/get-credentials-card.hbs b/ui/app/templates/components/get-credentials-card.hbs
@@ -22,9 +22,8 @@
     type="submit"
     value={{@title}}
     class="button is-secondary"
-    disabled={{buttonDisabled}}
+    disabled={{this.buttonDisabled}}
     onclick={{action "transitionToCredential"}}
     data-test-get-credentials
   />
-
 </form>
diff --git a/ui/app/templates/vault/cluster/secrets/backend/overview.hbs b/ui/app/templates/vault/cluster/secrets/backend/overview.hbs
@@ -52,6 +52,7 @@
           @searchLabel="Role to use"
           @backend={{model.backend}}
           @models={{array 'database/role'}}
+          @type="role"
         />
       </div>  
     </div>

diff --git a/ui/tests/acceptance/secrets/backend/database/secret-test.js b/ui/tests/acceptance/secrets/backend/database/secret-test.js
@@ -1,6 +1,6 @@
 import { module, test } from 'qunit';
 import { setupApplicationTest } from 'ember-qunit';
-import { currentURL, settled, click, visit, fillIn } from '@ember/test-helpers';
+import { currentURL, settled, click, visit, fillIn, typeIn } from '@ember/test-helpers';
 import { create } from 'ember-cli-page-object';
 import { selectChoose, clickTrigger } from 'ember-power-select/test-support/helpers';
 
@@ -408,15 +408,15 @@ module('Acceptance | secrets/database/*', function(hooks) {
     assert.dom('[data-test-secret-create]').hasText('Add role', 'Add role button exists with correct text');
     assert.dom('[data-test-edit-link]').hasText('Edit configuration', 'Edit button exists with correct text');
     const CONNECTION_VIEW_ONLY = `
-path "${backend}/*" {
-  capabilities = ["deny"]
-}
-path "${backend}/config" {
-  capabilities = ["list"]
-}
-path "${backend}/config/*" {
-  capabilities = ["read"]
-}
+      path "${backend}/*" {
+        capabilities = ["deny"]
+      }
+      path "${backend}/config" {
+        capabilities = ["list"]
+      }
+      path "${backend}/config/*" {
+        capabilities = ["read"]
+      }
     `;
     await consoleComponent.runCommands([
       `write sys/mounts/${backend} type=database`,
@@ -442,6 +442,9 @@ path "${backend}/config/*" {
       .dom('[data-test-selectable-card="Roles"]')
       .doesNotExist('Roles card does not exist on overview w/ policy');
     assert.dom('.title-number').hasText('1', 'Lists the correct number of connections');
+    // confirm get credentials card is an option to select. Regression bug.
+    await typeIn('.ember-text-field', 'blah');
+    assert.dom('[data-test-get-credentials]').isEnabled();
   });
 
   test('Role create form', async function(assert) {