ui: mfa: use proper request id generation (#17835)

* ui: mfa: use proper request id generation Fixes: 712cc9e, ca14c19 Signed-off-by: Konstantin Demin <rockdrilla@gmail.com> Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
hashicorp · Nov 29, 2022 · dfdb14b · dfdb14b
1 parent 5a9786f
commit dfdb14b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/changelog/17835.txt b/changelog/17835.txt
@@ -0,0 +1,3 @@
+```release-note:improvement
+ui: mfa: use proper request id generation
+```
diff --git a/ui/mirage/handlers/mfa-login.js b/ui/mirage/handlers/mfa-login.js
@@ -93,11 +93,7 @@ export default function (server) {
     } else if (user === 'mfa-j') {
       [mfa_constraints, methods] = generator([m('pingid')]); // use to test push failures
     }
-    const numbers = (length) =>
-      Math.random()
-        .toString()
-        .substring(2, length + 2);
-    const mfa_request_id = `${numbers(8)}-${numbers(4)}-${numbers(4)}-${numbers(4)}-${numbers(12)}`;
+    const mfa_request_id = crypto.randomUUID();
     const mfa_requirement = {
       mfa_request_id,
       mfa_constraints,