Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCSPClient.VerifyLeafCertificate() returns incorrect error messages #27126

Closed
anthonyralston opened this issue May 20, 2024 · 1 comment · Fixed by #27696
Closed

OCSPClient.VerifyLeafCertificate() returns incorrect error messages #27126

anthonyralston opened this issue May 20, 2024 · 1 comment · Fixed by #27696
Labels
bug Used to indicate a potential bug reproduced This issue has been reproduced by a Vault engineer sdk

Comments

@anthonyralston
Copy link

Describe the bug
Error messages returned in https://github.com/hashicorp/vault/blob/sdk/v0.12.0/sdk/helper/ocsp/client.go#L695-L714 refer to the issuer's serial number rather than the subject's serial number. It should be the subject's serial number that is returned.

To Reproduce
N/A

Expected behavior
Subject's serial number is returned.
@heatherezell heatherezell added sdk bug Used to indicate a potential bug labels May 22, 2024
@stevendpclark stevendpclark added the reproduced This issue has been reproduced by a Vault engineer label Jul 4, 2024
@stevendpclark stevendpclark mentioned this issue Jul 4, 2024
Merged
6 tasks
Merged
6 tasks
@stevendpclark
Copy link
Contributor

Thanks for reporting the issue @anthonyralston!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Used to indicate a potential bug reproduced This issue has been reproduced by a Vault engineer sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return the proper serial number in OCSP verification errors hashicorp/vault
3 participants
@stevendpclark @anthonyralston @heatherezell