Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audience support for k8 auth #6550

Open
AttwellBrian opened this issue Apr 8, 2019 · 5 comments
Open

Audience support for k8 auth #6550

AttwellBrian opened this issue Apr 8, 2019 · 5 comments

Comments

@AttwellBrian
Copy link

AttwellBrian commented Apr 8, 2019

Is your feature request related to a problem? Please describe.
When binding a k8 service account to a policy, there is no support for bound_audience like there is for GCE or JWT.

As a result, storing secrets in vault authenticated with service accounts is no safer than storing secrets in k8s secrets (since vault verifies the jwt derived from the service account's secret).

Describe the solution you'd like
Support for a bound_audience field when creating binding a new service account.

Vault should make some efforts to ensure authentication is being done from the correct k8s namespace.

@AttwellBrian
Copy link
Author

AttwellBrian commented Apr 8, 2019

Let me know if I should have posted this on the subproject https://github.com/hashicorp/vault-plugin-auth-kubernetes

@briankassouf briankassouf added this to the near-term milestone May 7, 2019
@pbernal pbernal modified the milestones: near-term, triaged May 28, 2020
@f4z3r
Copy link
Contributor

f4z3r commented Dec 2, 2022

I guess this was forgotten when this was implemented, as there is an audience parameter for the Kubernetes authentication that will validate the claim in the JWT (https://developer.hashicorp.com/vault/api-docs/auth/kubernetes#audience).

@maelvls
Copy link

maelvls commented Dec 14, 2022

I have noticed that the Kubernetes authentication does not actually validate the claim in the JWT when setting the audience parameter. I documented this issue in hashicorp/vault-plugin-auth-kubernetes#175.

@f4z3r
Copy link
Contributor

f4z3r commented Dec 14, 2022

Ah okay sorry I didn't check the code, as it sounded like a feature request and I saw the audience parameter on the API docs. I can have a look at this on Friday.

@hsimon-hashicorp
Copy link
Contributor

Hi folks! Is this still an issue in newer versions of Vault? Please let me know so I can bubble it up accordingly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants