Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL - Fix username generation length bug #10433

Merged
merged 4 commits into from Dec 1, 2020
Merged

Conversation

pcman312
Copy link
Contributor

@pcman312 pcman312 commented Nov 23, 2020

Fixes an issue where the display name in MySQL dynamic users is the incorrect length.

This also update the github.com/ory/dockertest dependency because it was failing to build locally.

Fixes #10476

@pcman312 pcman312 added bug Used to indicate a potential bug secret/database/mysql labels Nov 23, 2020
@pcman312 pcman312 added this to the 1.6.1 milestone Nov 23, 2020
Copy link
Contributor

@Valarissa Valarissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a much better way of isolating the differences for username lengths. I heartily approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug secret/database/mysql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vault 1.6 breaks mysql-legacy-plugin
3 participants