Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating GCP secrets plugin #10759

Merged
merged 3 commits into from Jan 26, 2021
Merged

Updating GCP secrets plugin #10759

merged 3 commits into from Jan 26, 2021

Conversation

Valarissa
Copy link
Contributor

This is bumping the GCP secrets plugin to 0.8.2

@Valarissa Valarissa added this to the 1.6.3 milestone Jan 25, 2021
@vercel
Copy link

vercel bot commented Jan 25, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

vault-storybook – ./ui

🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/8e37ot8xg
✅ Preview: Canceled

[Deployment for 88fb4b2 canceled]

@vercel vercel bot temporarily deployed to Preview – vault January 25, 2021 18:57 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook January 25, 2021 18:57 Inactive
@Valarissa Valarissa modified the milestones: 1.6.3, 1.6.2 Jan 25, 2021
austingebauer
austingebauer reviewed Jan 25, 2021
View reviewed changes
Copy link
Member

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the target branch here supposed to be master? If I recall correctly, tagged releases (v0.8.2) from plugin branches (release/vault-1.6.x) should only go into Vault release branches (release/1.6.x).

@Valarissa Valarissa closed this Jan 25, 2021
@Valarissa Valarissa reopened this Jan 25, 2021
@Valarissa
Copy link
Contributor Author

I updated this PR to update the pseudo-tag for master branch.

@Valarissa Valarissa merged commit 95c60e2 into master Jan 26, 2021
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
@jartek
Updating GCP secrets plugin (hashicorp#10759)
28ef6f9 
* Update gcp secrets plugin pseudo tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austingebauer austingebauer austingebauer left review comments

@calvn calvn calvn approved these changes

@catsby catsby Awaiting requested review from catsby

@pcman312 pcman312 Awaiting requested review from pcman312

Assignees
No one assigned
Labels
ecosystem/plugin
Projects
None yet
Milestone
1.6.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Valarissa @calvn @austingebauer