Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/Database Secrets Engine cleanup #10949

Merged
merged 7 commits into from Feb 19, 2021
Merged

UI/Database Secrets Engine cleanup #10949

merged 7 commits into from Feb 19, 2021

Conversation

chelshaw
Copy link
Contributor

A few straggling issues from the main sidebranch.

  • Serialization for non-array values specific to MongoDB
  • Fix defaultShown on info-table-row to not show default unless there is no value
  • Remove root rotation statements from mongodb connection fields
  • wrap router in try/catch if in promise's then

@chelshaw chelshaw added the ui label Feb 19, 2021
@chelshaw chelshaw added this to the 1.7 milestone Feb 19, 2021
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks for tackling these!

@vercel vercel bot temporarily deployed to Preview – vault February 19, 2021 19:51 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 19, 2021 19:51 Inactive
@chelshaw chelshaw merged commit 2ef0d92 into master Feb 19, 2021
@chelshaw chelshaw deleted the ui/dbse-cleanup branch February 19, 2021 20:04
catsby added a commit that referenced this pull request Feb 19, 2021
* master:
  Adds API docs for max_age role parameter of JWT/OIDC auth method (#10916)
  UI/Database Secrets Engine cleanup (#10949)
  helper/metricsutil: Prevent potential Ticker leak (#10913)
  core/expiration: Add backoff jitter to the expiration retries (#10937)
  Revert "Vault Dependency Upgrades [VAULT-871] (#10903)" (#10939)
  Vault Dependency Upgrades [VAULT-871] (#10903)
  Add docs for Agent's template_retry option added in #10644, based on those from consul-template configuration.  Also fix some existing config docs that weren't adhering to our conventions. (#10911)
  UI Database Secrets Engine (MongoDB) (#10655)
  OpenAPI - Don't panic if field isn't found (#10929)
  Vault-1403 Switch Expiration Manager to use Fairsharing Backpressure (#1709) (#10932)
  Update KV Secrets Engine index (#10933)
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
* Update role toolbar, serialization for special mongo values

* Only show defaultShown if no value on info table row

* Remove root_rotation_statements from mongo connection fields

* Wrap this.router in try/catch if in then statement

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants