UI: Add the wizard to the database secret engine #10982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelshaw
reviewed
Feb 23, 2021
chelshaw
reviewed
Feb 23, 2021
Monkeychip
commented
Feb 23, 2021
| <div class="progress-container"> | ||
| {{#each progressBar as |bar|}} | ||
| {{#each @progressBar as |bar|}} |
There was a problem hiding this comment.
the reason the progress bar wasn't showing, bug after ember upgrade
chelshaw
approved these changes
Feb 23, 2021
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
* wizard setup * cleanup * add changelog * fix names from save to create role and create database * fix missing progress bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Wizard designs to the DBSE engine.
*Note: confirmed with designs that the save buttons when creating a database and role should be "Create database" and "Create role" respectively. I spotted this in the difference between designs for the wizard vs. the ones for creating a role.
See screenshots (the copy is based on designs):