Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Fix status menu bug #11213

Merged
merged 4 commits into from
Mar 26, 2021
Merged

UI: Fix status menu bug #11213

merged 4 commits into from
Mar 26, 2021

Conversation

Monkeychip
Copy link
Contributor

@Monkeychip Monkeychip commented Mar 26, 2021 •
edited
Loading

Fix an error where the status menu does not show on the initial login. The workaround was to refresh. This fix gets us back to the expected behavior.

@Monkeychip Monkeychip added bug Used to indicate a potential bug ui labels Mar 26, 2021
@Monkeychip Monkeychip added this to the 1.7 milestone Mar 26, 2021
chelshaw
chelshaw approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@chelshaw chelshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

such a small change, such destructive behavior 🐛 🪓

@vercel vercel bot temporarily deployed to Preview – vault March 26, 2021 14:52 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 26, 2021 14:52 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 26, 2021 15:30 Inactive
@vercel vercel bot temporarily deployed to Preview – vault March 26, 2021 15:34 Inactive
@Monkeychip Monkeychip merged commit ffde6c6 into master Mar 26, 2021
@Monkeychip Monkeychip deleted the ui/status-menu-fix branch March 26, 2021 15:53
Monkeychip added a commit that referenced this pull request Mar 26, 2021
@Monkeychip
UI: Fix status menu bug (#11213)
f1cb42e 
* change null to empty string

* add changelog

* add conditional

* amend to set path
@Monkeychip Monkeychip mentioned this pull request Mar 26, 2021
Merged
Monkeychip added a commit that referenced this pull request Mar 26, 2021
@Monkeychip
UI: Fix status menu bug (#11213) (#11214)
3e259ad 
* change null to empty string

* add changelog

* add conditional

* amend to set path
AndreyZamyslov pushed a commit to yandex-cloud/vault that referenced this pull request Jun 10, 2021
@Monkeychip @AndreyZamyslov
UI: Fix status menu bug (hashicorp#11213)
14c1a50 
* change null to empty string

* add changelog

* add conditional

* amend to set path
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
@Monkeychip @jartek
UI: Fix status menu bug (hashicorp#11213)
030e697 
* change null to empty string

* add changelog

* add conditional

* amend to set path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelshaw chelshaw chelshaw approved these changes

Assignees
No one assigned
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Monkeychip @chelshaw