UI/fix kvv2 version #11258
Merged
UI/fix kvv2 version #11258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
approved these changes
Apr 2, 2021
chelshaw
added a commit
that referenced
this pull request
Apr 2, 2021
* Update default form values for kv * Group kv version option in 'Method Options' group * Fix tests, explicitly set if select input does not have default * Handle array of objects from adapterError.errors in MessageError component * Add changelog
chelshaw
added a commit
that referenced
this pull request
Apr 2, 2021
AndreyZamyslov
pushed a commit
to yandex-cloud/vault
that referenced
this pull request
Jun 10, 2021
* Update default form values for kv * Group kv version option in 'Method Options' group * Fix tests, explicitly set if select input does not have default * Handle array of objects from adapterError.errors in MessageError component * Add changelog
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
* Update default form values for kv * Group kv version option in 'Method Options' group * Fix tests, explicitly set if select input does not have default * Handle array of objects from adapterError.errors in MessageError component * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unselected dropdown option caused a bug when enabling a v2 secrets engine and creating a secret, where the UI didn't recognize that the new secrets engine was
version 2until a refresh caused a new network request. In addition to correctly setting the default kv version to 2, we moved that option under the Method Options dropdown:This PR also updates the
MessageErrorcomponent to better handle the type of error that was resulting in a message like[object Object], so that arrays of objects are instead passed into the component as strings