Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a more strict formatter over the code #11312

Merged
merged 3 commits into from Apr 8, 2021
Merged

Run a more strict formatter over the code #11312

merged 3 commits into from Apr 8, 2021

Conversation

briankassouf
Copy link
Member

This updates the make fmt command to use gofumpt to format the code. gofumpt can be installed by calling make bootstrap

Copy link
Member

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks so much neater and consistent! This is great.

Copy link
Contributor

@raskchanky raskchanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@briankassouf briankassouf merged commit a24653c into master Apr 8, 2021
@briankassouf briankassouf deleted the go-fumpt branch April 8, 2021 16:43
catsby added a commit that referenced this pull request Apr 14, 2021
* master: (78 commits)
  docs: update vault-helm to 0.11.0 (#11355)
  Add documentation for vault-csi-provider namespace config (#11344)
  docs: update vault-k8s to 0.10.0 (#11354)
  patch(docs): fix link color (#11352)
  Add TFE/TFC auth plugin to plugin portal (#11348)
  fix a couple typos (#11343)
  TLS Diagnose Formatting Fixes  (#11342)
  Add More TLS Tests and Verification of TLS Root Certificate (#11300)
  Add HA only autopilot to changelog (#11339)
  Support autopilot when raft is for HA only (#11260)
  Fixes for db connection file type field (#11331)
  Fix flakey TestAgent_Template_Retry test (#11332)
  Darwin/ARM64 build target (#11321)
  Fix broken OIDC Providers link (#11327)
  Bug: DB secret engine not showing "Select one" in role select options (#11294)
  bumping alpine version, improving security (#11271)
  Run a more strict formatter over the code (#11312)
  docs: add persistent cache (#11272)
  Fix a few static analysis findings (#11307)
  Changing from "changelog" to "release-note" (#11303)
  ...
AndreyZamyslov pushed a commit to yandex-cloud/vault that referenced this pull request Jun 10, 2021
* Update tooling

* Run gofumpt

* go mod vendor
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
* Update tooling

* Run gofumpt

* go mod vendor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants