Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mysql deadlock #11320

Closed
wants to merge 3 commits into from
Closed

Fix mysql deadlock #11320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46d2927
Fix: Deadlock in MySQL/MariaDB HA backend
thingstad Apr 8, 2021
7be2a47
Chore: Added changelog file with issue reference
thingstad Apr 8, 2021
ab98043
Chore: Added changelog text
thingstad Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/11319.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
physical/mysql: Fix multi master issue after lost connection.
```
6 changes: 4 additions & 2 deletions physical/mysql/mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,8 +576,8 @@ func (i *MySQLHALock) hasLock(key string) error {
var result sql.NullInt64
err := i.in.statements["used_lock"].QueryRow(key).Scan(&result)
if err == sql.ErrNoRows || !result.Valid {
// This is not an error to us since it just means the lock isn't held
return nil
// Signal we do no longer possess the lock, hence we need to step-down as leader.
return ErrLockLost
}

if err != nil {
Expand Down Expand Up @@ -630,6 +630,8 @@ var (
GlobalLockID int64
// ErrLockHeld is returned when another vault instance already has a lock held for the given key.
ErrLockHeld = errors.New("mysql: lock already held")
// ErrLockLost is returned when you are monitoring you leader lock, but your lock is lost.
ErrLockLost = errors.New("mysql: lock lost")
// ErrUnlockFailed
ErrUnlockFailed = errors.New("mysql: unable to release lock, already released or not held by this session")
// You were unable to update that you are the new leader in the DB
Expand Down