Capabilities endpoint #1171
Merged
Capabilities endpoint #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| type capabilitiesResponse struct { | ||
| Message string `json:"message"` |
There was a problem hiding this comment.
Having a separate message feedback mechanism is inconsistent with the rest of Vault. I don't think it's really needed. If there are no capabilities, simply return ["deny"] since that's the default. If it's root, I'd take advantage of the Warnings field (resp.AddWarning) and return the notification that way.
There was a problem hiding this comment.
I was wanting to ask you about Warnings. Thanks!
I'll do this.
vishalnayak
force-pushed
the
capabilities-endpoint
branch
2 times, most recently
from
c5ae867
to
a510b80
Compare
vishalnayak
force-pushed
the
capabilities-endpoint
branch
from
a510b80
to
7f832f2
Compare
vishalnayak
force-pushed
the
capabilities-endpoint
branch
from
d1474ee
to
b5ca8ba
Compare
| Usage: vault capabilities [options] [token] path | ||
|
|
||
| Fetch the capabilities of a token on a given path. | ||
| If a token is provided as an argument, '/sys/capabilities' endpoint will be invoked |
There was a problem hiding this comment.
nitpick: it should be "the '/sys/capabilities' endpoint..."
rajanadar
added a commit
to rajanadar/VaultSharp
that referenced
this pull request
Aug 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1069