Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved client content from cloud to vault #11776

Merged
merged 2 commits into from
Jun 7, 2021
Merged

moved client content from cloud to vault #11776

merged 2 commits into from
Jun 7, 2021

Conversation

taoism4504
Copy link
Contributor

@taoism4504 taoism4504 commented Jun 4, 2021 •
edited by yhyakuna

🔍 Deploy preview

  • Moved the What is a Client? doc from cloud.hashicorp.com repo to vault repo.

@taoism4504 taoism4504 added docs-cherrypick website Code changes specifically for the docs website labels Jun 4, 2021
@taoism4504 taoism4504 requested a review from yhyakuna June 4, 2021 20:18
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 4, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

ncabatoff
ncabatoff approved these changes Jun 4, 2021
View reviewed changes
Copy link
Collaborator

@ncabatoff ncabatoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to read through this text carefully since I assume that's already been done before the HCP version went live. I perused it to make sure that there aren't any HCP-isms left and that the structure looks sensible.

@yhyakuna yhyakuna added docs-cherrypick website Code changes specifically for the docs website and removed docs-cherrypick website Code changes specifically for the docs website labels Jun 4, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook June 7, 2021 19:12 Inactive
@vercel vercel bot temporarily deployed to Preview – vault June 7, 2021 19:12 Inactive
yhyakuna
yhyakuna approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@yhyakuna yhyakuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhyakuna yhyakuna merged commit 1beefcf into master Jun 7, 2021
@yhyakuna yhyakuna deleted the doc-update-client-count branch June 7, 2021 21:19
github-actions bot pushed a commit that referenced this pull request Jun 7, 2021
@taoism4504 @mdeggies @actions-user
moved client content from cloud to vault (#11776)
9acf9aa 
* moved client content from cloud to vault

* Empty commit trigger

Co-authored-by: Michele <mdeggies@gmail.com>
@yhyakuna yhyakuna mentioned this pull request Jun 8, 2021
Closed
AndreyZamyslov pushed a commit to yandex-cloud/vault that referenced this pull request Jun 10, 2021
@taoism4504 @mdeggies @AndreyZamyslov
moved client content from cloud to vault (hashicorp#11776)
9810124 
* moved client content from cloud to vault

* Empty commit trigger

Co-authored-by: Michele <mdeggies@gmail.com>
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
@taoism4504 @mdeggies @jartek
moved client content from cloud to vault (hashicorp#11776)
bcffc4b 
* moved client content from cloud to vault

* Empty commit trigger

Co-authored-by: Michele <mdeggies@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalnayak vishalnayak vishalnayak approved these changes

@ncabatoff ncabatoff ncabatoff approved these changes

@yhyakuna yhyakuna yhyakuna approved these changes

@mikegreen mikegreen Awaiting requested review from mikegreen

Assignees
No one assigned
Labels
website Code changes specifically for the docs website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@taoism4504 @hashicorp-cla @vishalnayak @ncabatoff @yhyakuna @mdeggies