Pad TOTP input key so that it can be parsed by base32.DecodeString #11887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
approved these changes
Jul 8, 2021
|
Hi @MartinLeedotOrg, This looks great, thanks! Could I trouble you to add a changelog entry, as per https://github.com/hashicorp/vault/blob/main/CONTRIBUTING.md#changelog-entries ? |
Add padding to the input key to ensure it reaches that length.
|
Done! |
|
Thanks! |
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
Add padding to the input key to ensure it reaches that length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base32.DecodeString expects length 8 for the buffer
Resolves issue #11874