Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Exit test process if vault fails to initialize #11998

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

hashishaw
Copy link
Collaborator

This is a developer ease-of-life update which has the test script exit with an error code if Vault does not start up when the tests start running (for example, if the vault binary is enterprise but you don't have a license). This avoids UI tests falsely failing due to API calls failing.

@hashishaw hashishaw added the ui label Jul 6, 2021
@hashishaw hashishaw added this to the 1.8 milestone Jul 6, 2021
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for tackling this.

@hashishaw hashishaw merged commit a9107dc into main Jul 9, 2021
@hashishaw hashishaw deleted the ui/vault-test-failsafe branch July 9, 2021 19:30
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants