Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kv custom key metadata #12218

Merged
merged 8 commits into from Aug 23, 2021
Merged

Add kv custom key metadata #12218

merged 8 commits into from Aug 23, 2021

Conversation

ccapurso
Copy link
Contributor

@ccapurso ccapurso commented Jul 30, 2021

This PR resolves #7905 - adding custom metadata to the kv-v2 secrets engine. The engine changes have been implemented in vault-plugin-secrets-kv #48.

The main functionality change in this PR is the addition of the -custom-metadata flag to the vault kv metadata put CLI command. Custom metadata will be string-to-string key-value pairs. The -custom-metadata flag can be specified multiple times to add multiple pieces of metadata.

@vercel vercel bot temporarily deployed to Preview – vault-storybook August 9, 2021 18:23 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 10, 2021 16:43 Inactive
@vercel vercel bot temporarily deployed to Preview – vault August 10, 2021 16:43 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 11, 2021 13:36 Inactive
@vercel vercel bot temporarily deployed to Preview – vault August 11, 2021 13:36 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 11, 2021 18:22 Inactive
@vercel vercel bot temporarily deployed to Preview – vault August 11, 2021 18:22 Inactive
@ccapurso ccapurso requested a review from a team August 11, 2021 18:22
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 12, 2021 14:35 Inactive
@vercel vercel bot temporarily deployed to Preview – vault August 12, 2021 14:35 Inactive
@vercel vercel bot temporarily deployed to Preview – vault August 23, 2021 13:56 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 23, 2021 13:56 Inactive
@ccapurso ccapurso added this to the 1.9 milestone Aug 23, 2021
Copy link
Collaborator

@ncabatoff ncabatoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not too familiar with the kv secrets engine release process, but it looks like we were using a tag up to now. Can you work with ecosystem to see if your change can be tagged so we maintain that?

@ccapurso
Copy link
Contributor Author

ccapurso commented Aug 23, 2021

Looks good. Not too familiar with the kv secrets engine release process, but it looks like we were using a tag up to now. Can you work with ecosystem to see if your change can be tagged so we maintain that?

@ncabatoff, I worked with the ecosystem team. I was steered toward using @master for the temporary version since we have not cut release/1.9.x branches yet. This will be rectified during the future release process.

@ccapurso ccapurso merged commit f421fa9 into main Aug 23, 2021
@ccapurso ccapurso deleted the add-kv-custom-key-metadata branch August 23, 2021 19:49
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
* add custom-metdata flag to "kv metadata put" command

* add kv metadata put command test for custom-metadata flag

* add custom_metadata to kv-v2 api docs

* add custom_metadata to kv-v2 cli docs

* update go.mod

* Add custom metadata limits to docs

* add changelog entry

* update vault-plugin-secrets-kv to @master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store user specified values in kv v2 secrets metadata
2 participants