New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kv custom key metadata #12218
Add kv custom key metadata #12218
Conversation
71d9cdd
to
b2e06dc
Compare
195076f
to
af0d7b8
Compare
af0d7b8
to
24dcf4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Not too familiar with the kv secrets engine release process, but it looks like we were using a tag up to now. Can you work with ecosystem to see if your change can be tagged so we maintain that?
@ncabatoff, I worked with the ecosystem team. I was steered toward using |
* add custom-metdata flag to "kv metadata put" command * add kv metadata put command test for custom-metadata flag * add custom_metadata to kv-v2 api docs * add custom_metadata to kv-v2 cli docs * update go.mod * Add custom metadata limits to docs * add changelog entry * update vault-plugin-secrets-kv to @master
This PR resolves #7905 - adding custom metadata to the kv-v2 secrets engine. The engine changes have been implemented in vault-plugin-secrets-kv #48.
The main functionality change in this PR is the addition of the
-custom-metadata
flag to thevault kv metadata put
CLI command. Custom metadata will be string-to-string key-value pairs. The-custom-metadata
flag can be specified multiple times to add multiple pieces of metadata.