[🚧 POC: not for merge] @hashicorp/ember-flight-icons test

[amyrlam]

Quick proof of concept (POC) of https://www.npmjs.com/package/@hashicorp/ember-flight-icons in Vault

Thanks to Michael Lange's help, I ended up downloading Vault from https://www.vaultproject.io/ and running vault server -dev along with cd ui && yarn start to run local dev. (Previously got stuck on various dev env woes, but am chipping away at those!)

Tagging Vault UI eng & design, as well as some of the Design Systems team for reference.

• TODO: Next steps would be to get this queued on the Vault Jira board, for when you have bandwidth, I'll xpost in Slack

[amyrlam]

wanted to crosspost from slack convo to explain what i meant:

• the structure-icons included some padding as part of the .svg file. the flight icons do not include padding within the .svg
• i added 4px horizontal spacing between the default 16 size flight icon and adjacent inline text, which i think looks fine
• eventually we should bring those recommendations to the documentation of flight https://github.com/hashicorp/flight (link in the upper RHS, just sharing the repo in case the vercel link changes)

[amyrlam]

update: we're at a 1.0.0 now and this could be updated!

but will wait to make further changes til y'all are working on it (no rush on our end)

[hashishaw]

This is an excellent POC @amyrlam, thank you for putting it together!

I'm pleased that the changes don't seem very drastic, although the considerations top of mind as we take this forward are:

• mapping between old glyph names and new ones (this may involve manual testing, or maybe we can extend FlightIcon with an assertion about @name value being valid. Does that already exist?)
• I'm sure there are a million little places where we handle icon spacing -- I wonder if there's a better systematic way to do that 🤔

[amyrlam]

@chelshaw hey welcome back! there's not a firm timeline on this, but it would be nice to chip away at deprecating structure-icons, esp if new designs with icons come up.

here's a list of mappings in the repo: https://github.com/hashicorp/flight/blob/main/structure-mappings.json

• we should make that legacy => new mapping more clear on our site, i made this ticket: Make mappings of old legacy structure-icons names to new flight-icons names clearer in CONTRIBUTING or where appropriate flight#281

there has been exploration of a codemod, but because many of the structure-icons included padding as part of the .svg, it's not something i've explored that much. that being said, let me look more into it. looks like the WIP of that is here hashicorp/flight#141

[amyrlam]

Close in favor of #12976, thank you @zofskeez!