Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport cert diff algo signing #12514 to 1.7.x #12549

Merged
merged 2 commits into from Sep 15, 2021

Conversation

sgmiller
Copy link
Collaborator

@sgmiller sgmiller commented Sep 14, 2021

No description provided.

#12514)

* WIP: Unset the certificate's SignatureAlgorithm to allown cross-signing of different key types

* Allow signing self issued certs with a different public key algorithm

* Remove cruft

* Remove stale import

* changelog

* eliminate errwrap

* Add a test to cover the lack of opt-in flag

* Better comment

Co-authored-by: catsby <clint@ctshryock.com>
@sgmiller sgmiller changed the title Allow signing self issued certs with a different public key algorithm. (#12514) Backport cert diff algo signing #12514 to 1.7.x Sep 14, 2021
Copy link
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the changes were the same as in the original fix.
👍

@vercel vercel bot temporarily deployed to Preview – vault September 15, 2021 14:53 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 15, 2021 14:53 Inactive
@sgmiller sgmiller merged commit 70afdc6 into release/1.7.x Sep 15, 2021
@sgmiller sgmiller deleted the backport-12514-1.7.x branch September 15, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants