Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.8.x: Port: Premature Rotation For autorotate (#12563) #12606

Merged
merged 1 commit into from
Sep 22, 2021

Commits on Sep 22, 2021

  1. Port: Premature Rotation For autorotate (#12563)

    * port of ldap fix for early cred rotation
    
    * some more porting
    
    * another couple lines to port
    
    * final commits before report
    
    * remove deadlock
    
    * needs testing
    
    * updates
    
    * Sync with OpenLDAP PR
    
    * Update the update error handling for items not found in the queue
    
    * WIP unit tests
    * Need to configure DB mount correctly, with db type mockv5
    * Need to find a way to inject errors into that mock db
    
    * throw error on role creation failure
    
    * do not swallow error on role creation
    
    * comment out wip tests and add in a test for disallowed role
    
    * Use newly generated password in WAL
    
    Co-authored-by: Michael Golowka <72365+pcman312@users.noreply.github.com>
    
    * return err on popFromRotationQueueByKey error; cleanup on setStaticAccount
    
    * test: fix TestPlugin_lifecycle
    
    * Uncomment and fix unit tests
    * Use mock database plugin to inject errors
    * Tidy test code to rely less on code internals where possible
    * Some stronger test assertions
    
    * Undo logging updates
    
    * Add changelog
    
    * Remove ticker and background threads from WAL tests
    
    * Keep pre-existing API behaviour of allowing update static role to act as a create
    
    * Switch test back to update operation
    
    * Revert my revert, and fix some test bugs
    
    * Fix TestBackend_StaticRole_LockRegression
    
    * clean up defer on TestPlugin_lifecycle
    
    * unwrap reqs on cleanup
    
    * setStaticAccount: don't hold a write lock
    
    * TestStoredWALsCorrectlyProcessed: set replication state to unknown
    
    Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
    Co-authored-by: Michael Golowka <72365+pcman312@users.noreply.github.com>
    Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com>
    4 people committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    4975173 View commit details
    Browse the repository at this point in the history