Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport 1.6.x: core: set namespace within GeneratePasswordFromPolicy (#12635) #12647

Merged
merged 1 commit into from Sep 27, 2021

Conversation

calvn
Copy link
Member

@calvn calvn commented Sep 27, 2021

  • core: set namespace from the sysview's mount entry on GeneratePasswordFromPolicy

  • test: update TestDynamicSystemView to be ns-aware, update tests

  • add changelog entry

* core: set namespace from the sysview's mount entry on GeneratePasswordFromPolicy

* test: update TestDynamicSystemView to be ns-aware, update tests

* add changelog entry
@calvn calvn added this to the 1.6.7 milestone Sep 27, 2021
@calvn calvn requested review from benashz and a team September 27, 2021 19:57
@vercel
Copy link

vercel bot commented Sep 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

vault – ./website

🔍 Inspect: https://vercel.com/hashicorp/vault/EZC2YTpBuoZ71PLpU5LGxPVnPyej
✅ Preview: Canceled

vault-storybook – ./ui

🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/Hr2DVrYRr7BzxyBqjyZmJz6W5Bc8
✅ Preview: Canceled

Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@calvn calvn merged commit eed8371 into release/1.6.x Sep 27, 2021
@calvn calvn deleted the backport-pr-12635-1.6.x branch September 27, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants