Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make etcd param MaxCallSendMsgSize configurable #12666

Merged
merged 6 commits into from Aug 16, 2023
Merged

make etcd param MaxCallSendMsgSize configurable #12666

merged 6 commits into from Aug 16, 2023

Conversation

antcs
Copy link
Contributor

@antcs antcs commented Sep 29, 2021

No description provided.

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 29, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot temporarily deployed to Preview – vault September 29, 2021 11:04 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 29, 2021 11:04 Inactive
@antcs antcs changed the title make max_call_size configurable make MaxCallSendMsgSize configurable Sep 29, 2021
@antcs antcs changed the title make MaxCallSendMsgSize configurable make etcd param MaxCallSendMsgSize configurable Sep 29, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 29, 2021 12:54 Inactive
@vercel vercel bot temporarily deployed to Preview – vault September 29, 2021 12:54 Inactive
@antcs
Copy link
Contributor Author

antcs commented Sep 29, 2021

@hellobontempo @sgmiller @victorr @kalafut Would you take a look at the PR?

ncabatoff
ncabatoff reviewed Oct 4, 2021
View reviewed changes
changelog/12666.txt Outdated Show resolved Hide resolved
@ncabatoff
Copy link
Collaborator

Hi @antcs,

Thanks for the PR! Would you mind updating the etcd docs (website/content/docs/configuration/storage/etcd.mdx) to reflect the new option?

@antcs antcs requested a review from taoism4504 as a code owner October 5, 2021 06:21
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 5, 2021 06:21 Inactive
@hsimon-hashicorp
Copy link
Contributor

Hello @antcs - wanted to check in and see if you would be able to update this PR to reflect the suggested changes. Please let me know if we can be of assistance! Thanks. :)

@taoism4504 taoism4504 added backport/website-deprecated Backport changes to `stable-website` and the latest `release/#.#.x` branch and removed docs-cherrypick labels Feb 4, 2022
@hsimon-hashicorp
Copy link
Contributor

@antcs Just wanted to check in again on this PR and the requested changes. :)

@hsimon-hashicorp
Copy link
Contributor

Hi @antcs just wanted to circle back and see if you're willing to make the requested changes. Let me know - thanks! :)

@antcs
Copy link
Contributor Author

antcs commented Sep 17, 2022

@hsimon-hashicorp @ncabatoff Would you take another look? Review was incorporated with the latest fixes.

@hsimon-hashicorp hsimon-hashicorp removed waiting-for-response backport/website-deprecated Backport changes to `stable-website` and the latest `release/#.#.x` branch labels Jan 24, 2023
@hsimon-hashicorp hsimon-hashicorp requested review from ccapurso and removed request for taoism4504 January 24, 2023 00:43
@ccapurso
Copy link
Contributor

Looks good, thanks for the contribution!

@ccapurso
Copy link
Contributor

@antcs, it looks like CI is having some issues. I'm not certain this will fix the issue but would you be able to try merging main into your branch?

@VioletHynes VioletHynes requested a review from a team as a code owner August 16, 2023 18:05
@VioletHynes
Copy link
Contributor

Thanks for the contribution! Going to get this merged!

@VioletHynes VioletHynes merged commit 35c0041 into hashicorp:main Aug 16, 2023
88 of 90 checks passed
rebwill pushed a commit that referenced this pull request Aug 18, 2023
@antcs @VioletHynes @rebwill
make etcd param MaxCallSendMsgSize configurable (#12666)
a8bbdf9 
* make max_call_size configurable

* add changelog

* update etcd docs and fix changelog

* rename to max_send_size

* docs variable fix

---------

Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncabatoff ncabatoff ncabatoff left review comments

@ccapurso ccapurso ccapurso approved these changes

@hghaf099 hghaf099 Awaiting requested review from hghaf099

Assignees
No one assigned
Labels
pr/no-changelog storage/etcd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@antcs @hashicorp-cla @ncabatoff @hsimon-hashicorp @ccapurso @VioletHynes @taoism4504