Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add patch section to kv-v2 api and CLI docs #12689

Merged
merged 8 commits into from Oct 22, 2021
Merged

add patch section to kv-v2 api and CLI docs #12689

merged 8 commits into from Oct 22, 2021

Conversation

ccapurso
Copy link
Contributor

No description provided.

@ccapurso ccapurso mentioned this pull request Sep 30, 2021
Merged
@vercel vercel bot temporarily deployed to Preview – vault-storybook September 30, 2021 21:06 Inactive
@ccapurso ccapurso added this to the 1.9 milestone Oct 1, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 1, 2021 20:47 Inactive
@ccapurso ccapurso mentioned this pull request Oct 4, 2021
Merged
@ccapurso ccapurso changed the title add data patch section to kv-v2 api docs add patch section to kv-v2 api docs Oct 4, 2021
@ccapurso ccapurso changed the title add patch section to kv-v2 api docs add patch section to kv-v2 api and CLI docs Oct 4, 2021
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 4, 2021 17:27 Inactive
@ccapurso ccapurso added the website Code changes specifically for the docs website label Oct 4, 2021
@ccapurso ccapurso marked this pull request as ready for review October 4, 2021 20:30
taoism4504
taoism4504 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@taoism4504 taoism4504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edit, but otherwise LGTM

@ccapurso @taoism4504
fix cas_required formatting
856f3e7 
Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 22, 2021 17:28 Inactive
@ccapurso @taoism4504
fix cas formatting
6c37dbc 
Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 22, 2021 17:28 Inactive
@ccapurso @taoism4504
additional format fixes
48c79a2 
Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 22, 2021 17:29 Inactive
@ccapurso
Copy link
Contributor Author

ccapurso commented Oct 22, 2021 •
edited

Thanks for the review, @taoism4504! I'm actually going to remove the docs-cherrypick label as these aren't ready to go live yet.

@ccapurso ccapurso merged commit 6aa76da into main Oct 22, 2021
@ccapurso ccapurso deleted the kv-v2-patch-doc-updates branch October 22, 2021 19:31
qk4l pushed a commit to qk4l/vault that referenced this pull request Feb 4, 2022
@ccapurso @taoism4504
add patch section to kv-v2 api and CLI docs (hashicorp#12689)
f3854a8 
* add data patch section to kv-v2 api docs

* fix trucated output for kv put command with cas cmd in kv-v2 docs

* wip vault kv patch CLI docs

* add new flags to 'vault kv patch' CLI command docs

* fix cas_required formatting

Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>

* fix cas formatting

Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>

* additional format fixes

Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>

Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoism4504 taoism4504 taoism4504 approved these changes

Assignees
No one assigned
Labels
pr/no-changelog secret/kv website Code changes specifically for the docs website
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ccapurso @taoism4504