Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LIST support to sys/policies/password #12787

Merged
merged 5 commits into from Jan 24, 2022
Merged

Add LIST support to sys/policies/password #12787

merged 5 commits into from Jan 24, 2022

Conversation

remilapeyre
Copy link
Contributor

Closes #12562

@vercel vercel bot temporarily deployed to Preview – vault-storybook October 10, 2021 17:34 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 10, 2021 18:22 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 10, 2021 18:22 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 10, 2021 18:37 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 10, 2021 18:37 Inactive
@vercel vercel bot temporarily deployed to Preview – vault October 10, 2021 18:37 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 10, 2021 18:37 Inactive
@calvn calvn changed the title Add read support to sys/policies/password Add LIST support to sys/policies/password Oct 19, 2021
@ccapurso ccapurso mentioned this pull request Oct 19, 2021
Closed
taoism4504
taoism4504 approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@taoism4504 taoism4504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remilapeyre @calvn
Add optional /
0ba0069 
Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – vault November 14, 2021 18:21 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook November 14, 2021 18:21 Inactive
@pmmukh
Copy link
Contributor

pmmukh commented Dec 17, 2021

Hi @remilapeyre ! Just wanted to drop a gentle nudge, if you could take a look at the feedback calvin provided and respond to those, it would be great, we're certainly interested in getting this change merged in. Thanks again for your contribution! :)

@vercel vercel bot temporarily deployed to Preview – vault-storybook December 31, 2021 19:31 Inactive
@remilapeyre
Copy link
Contributor Author

Hi @pmmukh! Everything should be good now!

HridoyRoy
HridoyRoy approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@HridoyRoy HridoyRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@HridoyRoy HridoyRoy merged commit 7c2ee26 into hashicorp:main Jan 24, 2022
qk4l pushed a commit to qk4l/vault that referenced this pull request Feb 4, 2022
@remilapeyre @calvn
Add LIST support to sys/policies/password (hashicorp#12787)
4f5aff9 
* Add read support to sys/policies/password

Closes hashicorp#12562

* Add changelog

* Empty commit to trigger CI

* Add optional /

Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com>

* Use a ListOperation

Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvn calvn calvn left review comments

@HridoyRoy HridoyRoy HridoyRoy approved these changes

@taoism4504 taoism4504 taoism4504 approved these changes

Assignees
No one assigned
Labels
core/policy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the LIST operation on /sys/policies/password to be able to list all password policies
7 participants
@remilapeyre @pmmukh @calvn @HridoyRoy @taoism4504 @ccapurso @hsimon-hashicorp