Backport pr 12747 1.6 #12838
Merged
Backport pr 12747 1.6 #12838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pmmukh
commented
Oct 14, 2021
•
pmmukh
commented
- Backport PR for VAULT-3252 Disallow alias creation if entity/accessor combination exists [VAULT-3252] Disallow alias creation if entity/accessor combination exists #12747
- Some differences exist between the changes there and here, due to some other identity changes that haven't been backported. The mergeEntity code uses i.core vs i.localNode, fromEntityIDs versus sanitizedFromEntityIDs, and does not use fromEntityGroups. The missing sanitizedFromEntityIDs is the only one relevant to the actual lines changes.
- Another change is that the identity website page lives in a separate place in 1.6, so made a separate commit to update that 14ada3d
…xists (#12747) * Disallow alias creation if entity/accessor combination exists * Add changelog * Address review comments * Add handling to aliasUpdate, some field renaming * Update tests to work under new entity-alias constraint * Add check to entity merge, other review fixes * Log duplicated accessors only once * Fix flaky test * Add note about new constraint to docs * Update entity merge warn log
|
This pull request is being automatically deployed with Vercel (learn more). vault – ./website🔍 Inspect: https://vercel.com/hashicorp/vault/HZXK8sWaamEDRGf8iBYDFtkJhBta vault-storybook – ./ui🔍 Inspect: https://vercel.com/hashicorp/vault-storybook/FKdChqsw5TsCkQzr9jeKgw89nVjn |
vishalnayak
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.